Java help

[FFRGreen]

Re: Java help

This was my old code

class DieRoll {
	public static void main ( String [] args) {
		
	String space;
	
	space = " ";
	Die die;
	
	
	die = new Die();

	
	
	die.roll();

	
	System.out.println("Your Results are" + space + die.getRoll());
	
	}
	
}

But then you changed it to this but you didn't add the die.roll() part and I was wondering where it went.

class DieRoll {
	public static void main ( String [] args) {

		
		Die die = new Die();
		
		for(int i = 0; i < 3; i++)
			System.out.println("Result: " + die.roll());
	}
}

[MaxGhost]

Re: Java help

Like I explained, you don't need it anymore the way I changed your roll() function.

Originally, roll() just randomized a number between 1 and 6, and gave that value to the 'number' variable. Now, roll() does the same as above, but also returns the value when called. What that means is that when you try to print 'die.roll()', it will replace that with the number it randomized.

[FFRGreen]

Re: Java help

Like I explained, you don't need it anymore the way I changed your roll() function.

Originally, roll() just randomized a number between 1 and 6, and gave that value to the 'number' variable. Now, roll() does the same as above, but also returns the value when called. What that means is that when you try to print 'die.roll()', it will replace that with the number it randomized.

Ok I got it thanks.


Also thanks to everyone else that helped me.

[Zageron]

Re: Java help

Now integrate it again without reviewing your old code.
MaxGhost was very helpful, but you should try to figure it out yourself as well.

[FFRGreen]

Re: Java help

Now integrate it again without reviewing your old code.
MaxGhost was very helpful, but you should try to figure it out yourself as well.

Yeah I got what he did I learn better if someone gives me an example.

[Izzy]

Re: Java help

Are you not allowed to use the random number generator that is built into java libraries?

Random r = new Random();

int num = r.nextInt(6) + 1;

[MrGiggles]

Re: Java help

you all have too many semi coloms, if you get rid of those ur prog will run much faster because CPU's have a tougher time with semi colons compared to alphanumeric characters

Are you not allowed to use the random number generator that is built into java libraries?

Random r = new Random();

int num = r.nextInt(6) + 1;

Yeah but I think the point of his assignment is to help familiarize him with how object-oriented programming operates, and it helps to make your own die class rather than just calling some dudebros random ass shit RNG

[rushyrulz]

Re: Java help

never in my life have I seen someone use a variable to represent " " rofl.

[Izzy]

Re: Java help

I just meant to use the random number generator inside of the Die class instead of using your own min and max values. I especially don't see the point in defining a variable to 0 and using that variable instead of 0 itself.

class Die {
	private int num;
        Random r = new Random();

	public Die() {
	       num = 0;
	}
	
	public void roll() {
		num = r.nextInt(6) + 1;
	}
	
	public int getRoll() {
		return num;
	}
}

never in my life have I seen someone use a variable to represent " " rofl.

Yea.. that really didn't make any sense, just put a space where you want a space. lol

[YoshL]

Re: Java help

class Die {

	private int num;

	public Die() {
	       num = 0;
	}
	
	public void roll() {
		num = (int) (Math.random() * 6) + 1;
	}
	
	public int getRoll() {
		return num;
	}
}

or you can use the Math.random() that's already there. no need to use another Random private instance i think

[rushyrulz]

Re: Java help

math commands <3

[MrGiggles]

Re: Java help

I just meant to use the random number generator inside of the Die class instead of using your own min and max values. I especially don't see the point in defining a variable to 0 and using that variable instead of 0 itself.

I guess it's possibly more secure that way? javadocs claims math.random is simpler for most applications but it's not like the random class is really complex or anything so idk.

I was told it's good practice to use constants whenever possible when I was learning Java, though I'm not sure exactly why (edit: probably so if you suddenly decide you want a 7 sided die that starts at 4 you can simply change the constants instead of ctrl-f-ing all instances of '6' and changing it to '7' or '0' to '3') so I don't worry about it too much, myself.

[MaxGhost]

Re: Java help

Math is automatically included whereas the Random class is not, so it makes your code bulkier to include classes not included by default.

Also constants are kind-of pointless in his case, cause he's not using it more than once. It saves memory and lines of code to not include the constants. YOSHl has it right, "num = (int) (Math.random() * 6) + 1;" is the better line of code. I still think returning as well is just generally useful to do.

[Izzy]

Re: Java help

You are probably right, I am not used to coding in java and am not familiar with the best method of generating a random number. If you look how to get random numbers in C or C++ it is kind of annoying if you aren't using predefined random number generators.

I remember I was making a command line dungeon game where you had to explore a 2D array and I was putting in traps and obstacles at random and for some reason it kept making the same dungeon even though I was using the Rand() function.

[Patashu]

Re: Java help

never in my life have I seen someone use a variable to represent " " rofl.

you're not supposed to use magic constants! what if the value of a space changes? you'll have to rewrite your entire program, but not this dude