Need some help with java

[inevitabledarkness]

Alright, I'm doing the program that asks for the length and height of a box. That part I got. What I can't seem to get is the part where it asks for an input by the user of which character to use when creating the box. Here's the code. Please help.
EDIT: Cleaner code.

import java.util.Scanner;
import java.lang.*;

/**
 * Michael Cuiffi
 * Period 8
 * 2/1/07
 **/
 
 public class DrawBox {
 	
 	public static void drawBox(int length, int height, String mark) {
 	
 		for (int i = 1; i <= height; i++){
 			drawBar(length, mark);
 		}
 		System.out.println();
 	}	
 	public static void drawBar(int length, String mark) {
 		
 		for (int i = 1; i <= length; i++) {
 			System.out.print(mark);
 		}
 		System.out.println();
 	}	
 		public static void main(String[] args) {
 			
 			int length, height;
 			String mark;
 			String choice;
 			Scanner s = new Scanner(System.in);
 			
 			System.out.print("Please enter the box's length: ");
 			length = s.nextInt();
 			System.out.print("Please enter the box's height: ");
 			height = s.nextInt();
 			System.out.print("Do you want to enter a character to use to display the box?\n(enter y for yes): ");
 			choice = s.nextLine();
 			System.out.println();
 			
 			if (choice != "Y") {
 				drawBox(length, height, "*");
 			} else if (choice == "Y") {
 				System.out.print("Please enter the character: ");
 				mark = s.nextLine();
 				drawBox(length, height, mark);
 			}
 			
 			
 		
 	}
 	
 	}

[AirForceBlue]

Re: Need some help with java

Hrm, what you want to use is an InputBox, most probably. I'm not really familiar with Java, but I'll do some research and edit this post when I find something out.

[RandomPscho]

Re: Need some help with java

InputBox NO WAY!!! -- I hate that book AirForce CSLib UGH!
EDIT: Woops, misread.
EDIT:

Ok, the problem:

System.out.print("Do you want to enter a character to use to display the box?\n(enter y for yes): ");
 			[b]choice = s.nextLine();[/b]

Should be

choice = s.next();

I am not sure what nextLine() actually does, but next() reads the user's string.

Also: you might want to add if (choice != "Y" || choice !="y") to account for lowercase y's

[MRTL_mrclean17]

Re: Need some help with java

I was testing this script and was wondering why nothing was showing up, then it dawned on me, this is Java, not JavaScript, which the former happens to be my specialty. Sorry I'm of no help.

[Zovistograt]

Re: Need some help with java

ARGH, no, please, never use boolean with Strings. Use

choice.equalsIgnoreCase(String)

instead. Also, use an else if thing like this...

if (choice.equalsIgnoreCase("Y")) System.out.println("some code...");
else if (choice.equalsIgnoreCase("N")) System.out.println("other code...");
else System.out.println("enter Y or N only!");

and 'course you should put that in a little while loop so that if they don't enter Y or N it just says it again.

[Zovistograt]

Re: Need some help with java

InputBox NO WAY!!! -- I hate that book AirForce CSLib UGH!
EDIT: Woops, misread.
EDIT:

Ok, the problem:

System.out.print("Do you want to enter a character to use to display the box?\n(enter y for yes): ");
 			[b]choice = s.nextLine();[/b]

Should be

I am not sure what nextLine() actually does, but next() reads the user's string.

Also: you might want to add if (choice != "Y" || choice !="y") to account for lowercase y's

nextLine() does the same thing...I thought you only use next() for Scanner stuffs with delimeters and all that semi-confusing annoyance.